build: add Fedora and Tubmleweed to the build matrix#3143
Merged
igaw merged 3 commits intolinux-nvme:masterfrom Mar 10, 2026
Merged
build: add Fedora and Tubmleweed to the build matrix#3143igaw merged 3 commits intolinux-nvme:masterfrom
igaw merged 3 commits intolinux-nvme:masterfrom
Conversation
Extend the build matrix to include Fedora and Tumbleweed for the main build (nvme-cli). Since the main build also includes libnvme, build libnvme standalone only on Debian with GCC. This is to catch configuration errors in Meson, and there is no additional information gained from the main build. Signed-off-by: Daniel Wagner <[email protected]>
The total length could be shorter than then the header. Thus check first the message length. Running test mi_aem_ep_based_failure_conditions...==3181== Conditional jump or move depends on uninitialised value(s) ==3181== at 0x486E7D7: validate_enabled_list (mi.c:1445) ==3181== by 0x486E7D7: nvme_mi_aem_get_enabled (mi.c:1730) ==3181== by 0x486E8F3: aem_disable_enabled (mi.c:1605) ==3181== by 0x486EB3A: nvme_mi_aem_enable (mi.c:1667) ==3181== by 0x401621: test_mi_aem_ep_based_failure_helper (mi-mctp.c:1187) ==3181== by 0x401688: test_mi_aem_ep_based_failure_conditions (mi-mctp.c:1204) ==3181== by 0x400FF2: run_test (mi-mctp.c:1448) ==3181== by 0x400FF2: main (mi-mctp.c:1472) Signed-off-by: Daniel Wagner <[email protected]>
valgrind complains about accessing not inialized data. Running test copy...==4327== Conditional jump or move depends on uninitialised value(s) ==4327== at 0x484E89E: bcmp (vg_replace_strmem.c:1234) ==4327== by 0x485D217: cmp (util.c:41) ==4327== by 0x485CE3C: ioctl (mock.c:188) ==4327== by 0x4870D1A: nvme_submit_passthru32 (ioctl.c:136) ==4327== by 0x4870EC3: nvme_submit_io_passthru (ioctl.c:183) ==4327== by 0x405595: test_copy (misc.c:1014) ==4327== by 0x406968: run_test (misc.c:1382) ==4327== by 0x406BF4: main (misc.c:1433) Signed-off-by: Daniel Wagner <[email protected]>
igaw
commented
Mar 9, 2026
| static int validate_enabled_list(struct nvme_mi_aem_supported_list *list, size_t len) | ||
| { | ||
| if (len < sizeof(struct nvme_mi_aem_supported_list)) | ||
| return -EPROTO; |
Collaborator
There was a problem hiding this comment.
Looks good to me!
This is @chorkin 's area, so might be good to get his input too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the build matrix and include Fedora and Tumbleweed for the main build (nvme-cli).
Since the main build also include libnvme, only build libnvme on debian with gcc as standalone. This is to catch configuration errors in meson and there is no additional information gained the the main build.